Skip to content

Match the beginning of a state's name as well as its verbose name#77

Open
mfilenko wants to merge 1 commit into
unitedstates:mainfrom
mfilenko:master
Open

Match the beginning of a state's name as well as its verbose name#77
mfilenko wants to merge 1 commit into
unitedstates:mainfrom
mfilenko:master

Conversation

@mfilenko
Copy link
Copy Markdown

This addresses #59 as well as some of other abbreviations.

@jcarbaugh
Copy link
Copy Markdown
Member

@mfilenko hope you've been well these past couple years since you've opened the PR and apologies for so poorly maintaining this package.

I think this is a good idea but would like to split things up a bit. I'm thinking of extracting the name cleaning into something like a separate clean_name method. That would make the normal lookup method work for some of the situations you test for here.

I'd likely rename the deep_lookup flag to something else more descriptive, but I can't think of anything just yet. startswith() is a good method but I'm wondering if there are other methods people might want to use here. Passing a fallback_func or something could allow someone to use their own fallback lookup method.

It's been a very long time since you opened this so I wouldn't ask you to make these changes. If you're good with this approach I'll close this PR, make the changes, and give you credit in README for the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants